Skip to content

feat(spring-data): Add option to disable filtering of 'OK' responses in pipelines#6708

Merged
mrniko merged 3 commits intoredisson:masterfrom
pengyongqiang666:fix-spring-data-redis-filtering-inconsistency
Sep 24, 2025
Merged

feat(spring-data): Add option to disable filtering of 'OK' responses in pipelines#6708
mrniko merged 3 commits intoredisson:masterfrom
pengyongqiang666:fix-spring-data-redis-filtering-inconsistency

Conversation

@pengyongqiang666
Copy link
Contributor

Fixes #6685

This PR addresses an inconsistency where Redisson's Spring Data pipeline/transaction implementation filters "OK" responses, while Lettuce and Jedis do not. This change makes the filtering behavior configurable to improve client substitutability.

Changes:

  • Added a filterOkResponses property to RedissonConnectionFactory.
  • The default is now false to align with Lettuce/Jedis behavior.
  • To restore the previous behavior, set this property to true.

For this initial review, I have only modified the redisson-spring-data-27 module. Upon approval, I will apply the same changes across all other redisson-spring-data-* versions.

…ns/Pipelines redisson#6685

Signed-off-by: pyq <pengyongqiang888@gmail.com>
Copy link
Member

@mrniko mrniko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test

@mrniko
Copy link
Member

mrniko commented Jul 25, 2025

any update?

@pengyongqiang666 pengyongqiang666 force-pushed the fix-spring-data-redis-filtering-inconsistency branch from 3769385 to e8c9e34 Compare July 28, 2025 06:42
Signed-off-by: pengyongqiang666 <pengyongqiang888@gmail.com>
@pengyongqiang666
Copy link
Contributor Author

I have submitted code

@mrniko
Copy link
Member

mrniko commented Aug 8, 2025

Looks good. Please apply this change to all modules.

Apply changes across versions 24-35 of redisson-spring-data modules.

Signed-off-by: pyq <pengyongqiang888@gmail.com>
@pengyongqiang666 pengyongqiang666 force-pushed the fix-spring-data-redis-filtering-inconsistency branch from 7784bba to f91ab58 Compare August 11, 2025 13:54
@pengyongqiang666
Copy link
Contributor Author

@mrniko I have completed applying the filterOkResponses changes to all redisson-spring-data modules as requested.

Applied to versions 24-35 of redisson-spring-data modules.

@mrniko mrniko merged commit d0def11 into redisson:master Sep 24, 2025
1 check passed
@mrniko
Copy link
Member

mrniko commented Sep 24, 2025

Thanks for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent Command Result Filtering in Spring Data Redis Transactions/Pipelines

2 participants