Expose more efficient async interfaces.#811
Merged
jaymell merged 1 commit intoredis-rs:mainfrom Mar 25, 2023
Merged
Conversation
Since the `async` keyword can't be used in traits, the ConnectionLike trait requires that the returned futures be boxed. This is necessary for the trait, but not for usage of the concrete connections. This change allows users to use the core logic without boxing the futures, thus reducing allocations. For example, the ConnectionManager now uses MultiplexedConnection's `send_packed_command`, thus removing the unnecessary boxing and according to DHAT, reducing allocations by half.
71b91ab to
d38aa5c
Compare
Contributor
|
Thanks, this looks great! |
jaymell
approved these changes
Mar 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the
asynckeyword can't be used in traits, the ConnectionLike trait requires that the returned futures be boxed. This is necessary for the trait, but not for usage of the concrete connections. This change allows users to use the core logic without boxing the futures, thus reducing allocations. For example, the ConnectionManager now uses MultiplexedConnection'ssend_packed_command, thus removing the unnecessary boxing and according to DHAT, reducing allocations by half.