Skip to content

Disabled SCH in MultiDBClient underlying clients#3938

Merged
vladvildanov merged 7 commits intomasterfrom
vv-geo-failover-disable-hitless
Feb 9, 2026
Merged

Disabled SCH in MultiDBClient underlying clients#3938
vladvildanov merged 7 commits intomasterfrom
vv-geo-failover-disable-hitless

Conversation

@vladvildanov
Copy link
Copy Markdown
Collaborator

@vladvildanov vladvildanov commented Feb 5, 2026

Description of change

Please provide a description of the change here.

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

@vladvildanov
Copy link
Copy Markdown
Collaborator Author

vladvildanov commented Feb 5, 2026

augment review

@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented Feb 5, 2026

🤖 Augment PR Summary

Summary: Disables Redis maintenance notifications for the underlying clients created by MultiDB helpers.

Changes:

  • Injects maint_notifications_config=MaintNotificationsConfig(enabled=False) alongside retry=Retry(retries=0) when constructing per-database clients in MultiDBClient.add_database() and MultiDbConfig.databases().
  • Adds a unit test to assert MultiDB’s underlying clients have retries disabled and do not create a maintenance-notifications pool handler.
Technical Notes: Keeps retries centralized in command_retry while preventing RESP3’s default maintenance-notifications initialization in leaf clients.

🤖 Was this summary useful? React with 👍 or 👎

augmentcode[bot]
augmentcode Bot reviewed Feb 5, 2026
View reviewed changes
Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 3 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread redis/multidb/client.py Outdated
Comment thread tests/test_multidb/test_config.py
Comment thread tests/test_multidb/test_config.py
petyaslavova
petyaslavova requested changes Feb 5, 2026
View reviewed changes
Comment thread redis/multidb/config.py Outdated
@kiryazovi-redis kiryazovi-redis mentioned this pull request Feb 6, 2026
Closed
4 tasks
petyaslavova
petyaslavova approved these changes Feb 9, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@petyaslavova petyaslavova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vladvildanov vladvildanov merged commit 877d7a2 into master Feb 9, 2026
139 of 145 checks passed
@vladvildanov vladvildanov deleted the vv-geo-failover-disable-hitless branch February 9, 2026 08:26
petyaslavova added a commit that referenced this pull request Feb 9, 2026
@vladvildanov @petyaslavova
Disabled SCH in MultiDBClient underlying clients (#3938)
b81c856 
* Disabled SCH in MultiDBClient underlying clients

* Fixed comment format

* Codestyle fixes

* Codestyle fixes

* Allow user to override maint_notifications_config

* Codestyle fixes

---------

Co-authored-by: petyaslavova <petya.slavova@redis.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petyaslavova petyaslavova petyaslavova approved these changes

+1 more reviewer

@augmentcode augmentcode[bot] augmentcode[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vladvildanov @petyaslavova