Skip to content

Move JedisMetaInfo into parent package and make it package private#3590

Merged
sazzad16 merged 2 commits into
redis:masterfrom
sazzad16:meta-java
Oct 19, 2023
Merged

Move JedisMetaInfo into parent package and make it package private#3590
sazzad16 merged 2 commits into
redis:masterfrom
sazzad16:meta-java

Conversation

@sazzad16

Copy link
Copy Markdown
Contributor

Along with #3589, I think this change makes sense.

@sazzad16 sazzad16 added the breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. label Oct 18, 2023
@sazzad16 sazzad16 added this to the 5.1.0 milestone Oct 18, 2023
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7882756) 71.46% compared to head (d8bf8f3) 71.46%.

❗ Current head d8bf8f3 differs from pull request most recent head 98b8cb7. Consider uploading reports for the commit 98b8cb7 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3590   +/-   ##
=========================================
  Coverage     71.46%   71.46%           
+ Complexity     4847     4846    -1     
=========================================
  Files           288      288           
  Lines         15452    15452           
  Branches       1093     1093           
=========================================
  Hits          11042    11042           
+ Misses         3934     3932    -2     
- Partials        476      478    +2     
Files Coverage Δ
src/main/java/redis/clients/jedis/Connection.java 81.17% <ø> (ø)
...c/main/java/redis/clients/jedis/JedisMetaInfo.java 68.75% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sazzad16 sazzad16 merged commit d4d46f9 into redis:master Oct 19, 2023
@sazzad16 sazzad16 deleted the meta-java branch October 19, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport required breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants