Skip to content

Feature: Triggers and functions commands#3531

Merged
sazzad16 merged 3 commits into
redis:masterfrom
bsbodden:bsb/feature-triggers-and-functions
Sep 23, 2023
Merged

Feature: Triggers and functions commands#3531
sazzad16 merged 3 commits into
redis:masterfrom
bsbodden:bsb/feature-triggers-and-functions

Conversation

@bsbodden

@bsbodden bsbodden commented Sep 12, 2023

Copy link
Copy Markdown
Contributor

Implements Triggers and Functions Commands:

sazzad16
sazzad16 suggested changes Sep 12, 2023
View reviewed changes
Comment thread src/test/java/redis/clients/jedis/modules/gears/GearsTest.java Outdated
Comment thread src/main/java/redis/clients/jedis/resps/GearsLibraryInfo.java Outdated
Comment thread src/main/java/redis/clients/jedis/gears/GearsArgs.java Outdated
Comment thread src/main/java/redis/clients/jedis/gears/RedisGearsCommands.java Outdated
Comment thread src/main/java/redis/clients/jedis/gears/RedisGearsCommands.java Outdated
@bsbodden bsbodden force-pushed the bsb/feature-triggers-and-functions branch from 72a0473 to 56f57ad Compare September 12, 2023 16:16
@bsbodden bsbodden requested a review from sazzad16 September 12, 2023 16:20
@sazzad16 sazzad16 added this to the 5.1.0 milestone Sep 13, 2023
@bsbodden bsbodden force-pushed the bsb/feature-triggers-and-functions branch from 5e6c87c to b9de0e3 Compare September 15, 2023 01:02
sazzad16
sazzad16 suggested changes Sep 17, 2023
View reviewed changes

@sazzad16 sazzad16 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With default (RESP2):

Error:  Failures: 
Error:    GearsTest.testLibraryCallHashResult:433 expected:<7> but was:<14>

@bsbodden bsbodden force-pushed the bsb/feature-triggers-and-functions branch from 243890c to d0a4fe2 Compare September 18, 2023 14:42
@bsbodden

bsbodden commented Sep 18, 2023

Copy link
Copy Markdown
Contributor Author

With default (RESP2):

Error:  Failures: 
Error:    GearsTest.testLibraryCallHashResult:433 expected:<7> but was:<14>

I was trying to check for the protocol in the tests assuming RedisProtocolUtil.getRedisProtocol() would return the right value. I changed to just check the data in flight for the test.

@bsbodden

bsbodden commented Sep 18, 2023

Copy link
Copy Markdown
Contributor Author

@sazzad16 I only see a failure now that seems unrelated:

Error:  Failures: 
Error:    ClusterPipeliningTest.multiple:1072->assertThreadsCount:1098 
Expected: a value less than or equal to <20>
     but: <21> was greater than <20>
[INFO] 
Error:  Tests run: 1241, Failures: 1, Errors: 0, Skipped: 27

@bsbodden bsbodden requested a review from sazzad16 September 19, 2023 14:16
@sazzad16 sazzad16 merged commit eadf6a0 into redis:master Sep 23, 2023
@sazzad16 sazzad16 mentioned this pull request Sep 23, 2023
Merged
sazzad16 added a commit that referenced this pull request Sep 23, 2023
@sazzad16
Polish Feature: Triggers and functions commands (#3551)
3c15285 
Polish #3531
This was referenced Sep 23, 2023
Closed
Merged
sazzad16 added a commit that referenced this pull request Sep 23, 2023
@sazzad16
Polish Triggers and functions tests (#3554)
eb6893a 
Polish #3531 tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sazzad16 sazzad16 Awaiting requested review from sazzad16

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

5.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@bsbodden @sazzad16