Support RESET command#3015
Conversation
sazzad16
left a comment
There was a problem hiding this comment.
Error: Tests run: 51, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 4.279 s <<< FAILURE! - in redis.clients.jedis.commands.jedis.AllKindOfValuesCommandsTest
Error: reset(redis.clients.jedis.commands.jedis.AllKindOfValuesCommandsTest) Time elapsed: 0.001 s <<< ERROR!
redis.clients.jedis.exceptions.JedisDataException: NOAUTH Authentication required.
at redis.clients.jedis.commands.jedis.AllKindOfValuesCommandsTest.reset(AllKindOfValuesCommandsTest.java:1142)
|
Hi, I fixed the unit test failure, and run it in my workflow: https://github.com/ihaohong/jedis/runs/6883129332?check_suite_focus=true, please review this pull request again, thanks. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3015 +/- ##
============================================
- Coverage 71.52% 71.46% -0.06%
+ Complexity 4851 4848 -3
============================================
Files 288 288
Lines 15461 15464 +3
Branches 1095 1095
============================================
- Hits 11058 11051 -7
- Misses 3927 3934 +7
- Partials 476 479 +3
☔ View full report in Codecov by Sentry. |
|
Hi, what else need me to do for this pull request? |
|
@ihaohong Nothing ATM. Thank you for your patience. |
|
@ihaohong Apologies for late and thanks for your contribution! |
No description provided.