Merged
Conversation
3ccc80d to
71d1a43
Compare
ndyakov
previously approved these changes
Jun 6, 2025
Member
ndyakov
left a comment
There was a problem hiding this comment.
@andy-stark-redis thank you for adding those. I fixed the testing infra to support newer redis version in the doctests CI step and changed the test.ci so it takes into consideration what should be excluded from the example tests. Not ideal, but we will work improve it iteratively.
71d1a43 to
b0fec1c
Compare
ndyakov
approved these changes
Jun 6, 2025
ofekshenawa
pushed a commit
to ofekshenawa/go-redis
that referenced
this pull request
Jun 30, 2025
ofekshenawa
pushed a commit
that referenced
this pull request
Aug 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DOC-5078
Go versions of the examples in the main vector set page, and also the performance and memory optimisation pages.
Note: some of the tests fail but I guess these are running against the previous version of Redis without vector set support? Is there any way to skip the doc tests in these cases?