Thank you @fukua95, will review as soon as possible.

@fukua95 we will have a discussion next week, overall I think the PR looks good, if the team agrees on the return types, I will merge this, thank you.

@fukua95 we will have a discussion next week, overall I think the PR looks good, if the team agrees on the return types, I will merge this, thank you.

Thank you for your review.

If there is anything that needs to be updated (the return types or others), please feel free to let me know.

One more thing: The VSim command in Redis code (unstable) has the option Epsilon, by the doc in Redis.io don't have. I'll modify the code after you decide whether to keep this option.

@fukua95 we are still not set on the return types, but one thing I will suggest is to use something similar to

@fukua95 we are still not set on the return types, but one thing I will suggest is to use something similar to

go-redis/sortedset_commands.go

Line 728 in 27581fc

type Z struct {

for the responses with scores. It will make this more consistent with the rest of the library and in general I don't see the benefit of having a map here - I don't see a lot of usecases that will benefit from the constant time to access an element. WDYT?

Using a struct is more user-friendly. I will update it soon.

Thank you @fukua95 , let me know if you need any help. You can also find me on Discord

Thank you @fukua95 , let me know if you need any help. You can also find me on Discord

Apologies for the delay @ndyakov - these days mark a holiday in my country, and I'm currently traveling.
I'll update the code tonight.

@ndyakov Thank you for the detailed review! I really appreciate your suggestions and I'll work on the updates tonight or tomorrow.

@fukua95 just a heads up, for the method that should clear the attributes - let's name it VClearAttributes to be able to distinguish it from other redis commands.

Hello, How about naming the method VClearAttr? This way it can be consistent with VSetAttr.

@fukua95 I was suggesting something similar to what you are suggesting, but the potential issue is that a user may think there is a redis command VClearAttr and that's why we voted and decided to have it completely different from the rest of the redis commands and name it VClearAttributes.

Got it, I've made the changes.

@fukua95 thank you, will review this asap and get back to you.

@fukua95 I hope you don't mind me pushing the last commit. After trying both implementations for VSetAttr I decided agains my initial suggestion and didn't want to ask you to redo it, so I did it.

Not at all. Thank you.

@cxljs bringing this to your attention redis/redis#14223

Thanks @ndyakov , I'll update it in a bit.