Add OpenTelemetry Native Metrics Support#3637
Merged
Merged
Conversation
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
5b7ff5f to
168f918
Compare
0940dd5 to
b8afd7f
Compare
…quest metric type from UpAndDownCounter to Async gauge.
ndyakov
reviewed
Jan 14, 2026
vladvildanov
requested changes
Jan 15, 2026
ndyakov
reviewed
Jan 15, 2026
ndyakov
reviewed
Jan 19, 2026
ndyakov
left a comment
Member
There was a problem hiding this comment.
left two comments that can be considered for all get/set operations. other than that the thread safety looks ok if we are willing to accept that there is a time window for which getters may have returned an old value. can we make sure if we remove the telemetry, this won't break the app? In the case when the old value is nil I assume we can accept a single event not being tracked.
ndyakov
reviewed
Jan 21, 2026
vladvildanov
previously approved these changes
Jan 23, 2026
ndyakov
previously approved these changes
Feb 4, 2026
ndyakov
left a comment
Member
There was a problem hiding this comment.
overall looks good, can merge as is, left couple of improvements that we can address
Member
|
@ofekshenawa let's resolve the comments here and work on merging this |
530cf26 to
b16d2d3
Compare
ndyakov
approved these changes
Feb 13, 2026
ndyakov
left a comment
Member
There was a problem hiding this comment.
Looks good to me, we can resolve:
#3637 (comment)
in a separate PR in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements Observability (Metrics) for go-redis, adding comprehensive OpenTelemetry metrics support following the OpenTelemetry Database Client Semantic Conventions.
The implementation uses a Bridge Pattern to keep the core library dependency-free while providing optional, metrics instrumentation through the new extra/redisotel-native package.
What's Included:
Metric groups covering aspects of Redis operations: