xinfo-groups: support nil lag in XINFO GROUPS#3369
Merged
Conversation
ndyakov
previously approved these changes
May 9, 2025
Member
ndyakov
left a comment
There was a problem hiding this comment.
Thank you, Can we please update the documentation for the Lag and note that it will return -1 when the Lag is nil.
Member
|
Let's just add a comment around command.go#2101 where the response type is defined and we are good to merge. |
e493a12 to
a1f128f
Compare
ndyakov
approved these changes
May 21, 2025
ofekshenawa
added a commit
to ofekshenawa/go-redis
that referenced
this pull request
Jun 30, 2025
* xinfo-groups: support nil lag in XINFO GROUPS * Add test * docs: clarify XInfoGroup.Lag field behavior with Nil values * docs: clarify XInfoGroup.Lag field behavior
ofekshenawa
added a commit
that referenced
this pull request
Aug 10, 2025
* xinfo-groups: support nil lag in XINFO GROUPS * Add test * docs: clarify XInfoGroup.Lag field behavior with Nil values * docs: clarify XInfoGroup.Lag field behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3185