fix node routing in slotClosestNode#3043
Merged
monkey92t merged 2 commits intoredis:masterfrom Jul 10, 2024
Merged
Conversation
Contributor
Author
|
@monkey92t please review this fix for the issue:#3023 |
monkey92t
approved these changes
Jul 10, 2024
Collaborator
monkey92t
left a comment
There was a problem hiding this comment.
Good, but using the nearest node each time will put a lot of stress on that node. We can optimize it further later.
Contributor
Author
|
@monkey92t when can we expect the next release? |
Collaborator
v9.5.3 |
Contributor
Author
@monkey92t this release doesn't include commits of this pr |
Collaborator
Changes
??? |
Contributor
Author
|
Line 732 in f752b9a The commits are there in master branch, but the release seems to be behind it |
Contributor
Author
Collaborator
|
It seems to have been affected. I'll take a look. |
Collaborator
|
@srikar-jilugu I've added a new version. v9.5.4 |
Contributor
Author
Thankyou! |
vladvildanov
pushed a commit
that referenced
this pull request
Jul 17, 2024
* fix node routing when all nodes are failing * fix minlatency zero value
ofekshenawa
pushed a commit
that referenced
this pull request
Aug 10, 2025
* fix node routing when all nodes are failing * fix minlatency zero value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.