Skip to content

Added test case for CLIENT KILL with MAXAGE option#2971

Merged
ofekshenawa merged 11 commits intoredis:masterfrom
vladvildanov:vv-client-kill-max-age
Jun 19, 2024
Merged

Added test case for CLIENT KILL with MAXAGE option#2971
ofekshenawa merged 11 commits intoredis:masterfrom
vladvildanov:vv-client-kill-max-age

Conversation

@vladvildanov
Copy link
Copy Markdown
Collaborator

Closes #2920

@vladvildanov vladvildanov self-assigned this Apr 15, 2024
Copy link
Copy Markdown
Collaborator

@monkey92t monkey92t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, we need to change the test Redis version to the unstable branch.

https://github.com/redis/redis/tree/unstable

@monkey92t
Copy link
Copy Markdown
Collaborator

The parameter has not been released in the stable version.

@vladvildanov
Copy link
Copy Markdown
Collaborator Author

@monkey92t Yeah, I got it. I'll work on this 👌

@vladvildanov
Copy link
Copy Markdown
Collaborator Author

@ofekshenawa Does tests fails because not supported or any other reason?

@ofekshenawa
Copy link
Copy Markdown
Collaborator

@vladvildanov yes, currently it's not supported.

@ofekshenawa ofekshenawa merged commit 0777247 into redis:master Jun 19, 2024
ofekshenawa added a commit that referenced this pull request Aug 10, 2025
* Added test case for CLIENT KILL with MAXAGE option

* Fixed sleep value

* Added additional condition to kill specific connection

* Test commit

* Test commit

* Updated test case to handle timeouts

---------

Co-authored-by: ofekshenawa <104765379+ofekshenawa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add command filter for CLIENT KILL to support maximum age via [MAXAGE] option

3 participants