Skip to content

[Symfony 7.3] add constant and test for 7.3 and test help to attribute #718#722

Merged
samsonasik merged 1 commit intorectorphp:mainfrom
JohJohan:main
Apr 24, 2025
Merged

[Symfony 7.3] add constant and test for 7.3 and test help to attribute #718#722
samsonasik merged 1 commit intorectorphp:mainfrom
JohJohan:main

Conversation

@JohJohan
Copy link
Contributor

@JohJohan JohJohan commented Apr 23, 2025 •
edited
Loading

From: #718

Thanks for the report. Rule is in very early stages, based on couple diffs of referenced PR, so any test fixture of the right setup will help.

Can you send a PR with the test fixture you expect?

We would need:

  1. Set support for symfony/console to 7.3 or at least define AsCommand has attribute help
  2. Write a rector rule who will move help to the attribute (and make sure this is done before InvokableCommandRector as that will remove configure in total.

@TomasVotruba
Copy link
Member

TomasVotruba commented Apr 23, 2025

Awesome, thanks for the test fixture 👍

Could you add fix as well?

JohJohan
JohJohan commented Apr 23, 2025
View reviewed changes
@TomasVotruba
Copy link
Member

TomasVotruba commented Apr 23, 2025

Looks good 👍

samsonasik
samsonasik reviewed Apr 23, 2025
View reviewed changes
@JohJohan JohJohan requested a review from samsonasik April 23, 2025 14:11
samsonasik
samsonasik reviewed Apr 23, 2025
View reviewed changes
@JohJohan JohJohan requested a review from samsonasik April 23, 2025 14:27
samsonasik
samsonasik reviewed Apr 23, 2025
View reviewed changes
samsonasik
samsonasik reviewed Apr 23, 2025
View reviewed changes
samsonasik
samsonasik reviewed Apr 23, 2025
View reviewed changes
@JohJohan JohJohan requested a review from samsonasik April 24, 2025 08:56
samsonasik
samsonasik reviewed Apr 24, 2025
View reviewed changes
@JohJohan
Copy link
Contributor Author

JohJohan commented Apr 24, 2025

@samsonasik note i did:

  1. Added fixture to call all for CommandConfigureToAttributeRector (to check that the output will work for CommandHelpToAttributeRector and InvokableCommandRector
  2. For InvokableCommandRector i made sure we also cleanup method chaining calls (also a fixture for this)
  3. For CommandConfigureToAttributeRector added a fixture that has all attributes set from example CommandConfigureToAttributeRector rule and will add help attribute

@JohJohan JohJohan requested a review from samsonasik April 24, 2025 10:30
@samsonasik
Copy link
Member

samsonasik commented Apr 24, 2025

Let's give it a try, thank you @JohJohan

@samsonasik samsonasik merged commit b3a4192 into rectorphp:main Apr 24, 2025
5 checks passed
@TomasVotruba
Copy link
Member

TomasVotruba commented Apr 24, 2025

Thakn you @JohJohan 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomasVotruba TomasVotruba TomasVotruba left review comments

@samsonasik samsonasik Awaiting requested review from samsonasik

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JohJohan @TomasVotruba @samsonasik