Skip to content

feat: add flysystem key#705

Merged
samsonasik merged 2 commits intorectorphp:mainfrom
dsdeboer:feat/add-flysystem-key
Mar 11, 2025
Merged

feat: add flysystem key#705
samsonasik merged 2 commits intorectorphp:mainfrom
dsdeboer:feat/add-flysystem-key

Conversation

@dsdeboer
Copy link
Copy Markdown
Contributor

@dsdeboer dsdeboer commented Mar 8, 2025

This PR adds the ability to auto convert the flysystem configuration

'maker' => 'Symfony\Config\MakerConfig',
'nelmio_cors' => 'Symfony\Config\NelmioCorsConfig',
'api_platform' => 'Symfony\Config\ApiPlatformConfig',
'flysystem' => 'Symfony\Config\FlysystemConfig',
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add @see link comment reference on it for future reference? Thank you.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ofcourse! Could you tell me where you want the link to point to?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just in above it, like:

       // @see ...
        'flysystem' => 'Symfony\Config\FlysystemConfig'

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, 4148bb7 is what you meant.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure I understand how the class work, is Symfony\Config\FlysystemConfig auto created on the fly? since your reference pointed to different class

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's correct. If you installed flysystem then the added class is automatically generated based on the reference. This works the same as currently for the other keys.

@samsonasik samsonasik merged commit d4e5a0f into rectorphp:main Mar 11, 2025
5 checks passed
@samsonasik
Copy link
Copy Markdown
Member

Thank you @dsdeboer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants