Do not change method if name does not need to change#700
Merged
samsonasik merged 1 commit intorectorphp:mainfrom Feb 14, 2025
Merged
Do not change method if name does not need to change#700samsonasik merged 1 commit intorectorphp:mainfrom
samsonasik merged 1 commit intorectorphp:mainfrom
Conversation
samsonasik
approved these changes
Feb 14, 2025
Member
|
Thank you @carlos-granados |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ActionSuffixRemoverRectordid not check if the new name was the same as the previous name and always tried to change it, resulting in the rule being reapplied with no need for it. This PR checks if the name needs to change and only updates the method if that is the case