Skip to content

Conversation

@samsonasik
Copy link
Member

Fixes rectorphp/rector#9310

Since symfony/console 6.4.24, the vendor/patch for symfony/console no longer valid. Remove the vendor patch resolve it.

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @ericwoelki

@samsonasik samsonasik changed the title [Console] Fix symfony/console diff broken on windows [Console] Fix symfony/console diff broken on windows on symfony/console 6.4.24 Aug 15, 2025
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 51dc24c into main Aug 15, 2025
49 checks passed
@samsonasik samsonasik deleted the fix-console branch August 15, 2025 08:20
@samsonasik
Copy link
Member Author

samsonasik commented Aug 15, 2025

The reason it now working is because symfony/string is now included in vendor scoped, see related PRs:

that previously on replace, but now required may due to latest myclabs/deep-copy:1.13.4

and in symfony/console 6.4.24, the helper used everywhere.

Try latest dev-main, and you're ok 👍

@ericwoelki
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken diff output in v2.1.3

3 participants