Skip to content

[TypeDeclaration] Handle crash on direct callable without params on AddArrayFunctionClosureParamTypeRector #7131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samsonasik merged 3 commits into from
Aug 9, 2025
Merged

[TypeDeclaration] Handle crash on direct callable without params on AddArrayFunctionClosureParamTypeRector #7131

samsonasik merged 3 commits into from
Aug 9, 2025

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Aug 9, 2025

It cause crash:

There was 1 error:

1) Rector\Tests\TypeDeclaration\Rector\FuncCall\AddArrayFunctionClosureParamTypeRector\AddArrayFunctionClosureParamTypeRectorTest::test with data set #3 ('/Users/samsonasik/www/rector-...hp.inc')
Error: Attempt to assign property "type" on null

/Users/samsonasik/www/rector-src/rules/TypeDeclaration/Rector/FuncCall/AddArrayFunctionClosureParamTypeRector.php:124
/Users/samsonasik/www/rector-src/src/Rector/AbstractRector.php:154

Ref https://getrector.com/demo/a1453e38-add0-4607-b8ea-00c0ecef703c
Ref https://3v4l.org/65A36#v8.0.1

@samsonasik samsonasik mentioned this pull request Aug 9, 2025
Merged
@samsonasik samsonasik changed the title [TypeDeclaration] Handle crash on direct callable with single arg on AddArrayFunctionClosureParamTypeRector [TypeDeclaration] Handle crash on direct callable with range 2nd arg on AddArrayFunctionClosureParamTypeRector Aug 9, 2025
@samsonasik samsonasik changed the title [TypeDeclaration] Handle crash on direct callable with range 2nd arg on AddArrayFunctionClosureParamTypeRector [TypeDeclaration] Handle crash on direct callable without params on AddArrayFunctionClosureParamTypeRector Aug 9, 2025
@samsonasik
Copy link
Member Author

samsonasik commented Aug 9, 2025

Fixed 🎉 /cc @TomasVotruba

@samsonasik
Copy link
Member Author

samsonasik commented Aug 9, 2025

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit b3e556c into main Aug 9, 2025
47 checks passed
@samsonasik samsonasik deleted the crash-single branch August 9, 2025 17:50
@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2026

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samsonasik