-
-
Notifications
You must be signed in to change notification settings - Fork 429
[Php85] Replace null return with empty array in __debugInfo #7124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
samsonasik
merged 2 commits into
rectorphp:main
from
mttsch:feature/php85-__debugInfo-null
Aug 11, 2025
Merged
[Php85] Replace null return with empty array in __debugInfo #7124
samsonasik
merged 2 commits into
rectorphp:main
from
mttsch:feature/php85-__debugInfo-null
Aug 11, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
Aug 9, 2025
samsonasik
reviewed
Aug 9, 2025
6ff97cf to
d9c40c7
Compare
samsonasik
reviewed
Aug 10, 2025
d0cbbb5 to
f0b15f8
Compare
samsonasik
reviewed
Aug 10, 2025
rules-tests/Php85/Rector/MethodCall/NullDebugInfoReturnRector/Fixture/normal_function.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Aug 10, 2025
...tests/Php85/Rector/MethodCall/NullDebugInfoReturnRector/Fixture/implicit_null_return.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Aug 10, 2025
...tests/Php85/Rector/MethodCall/NullDebugInfoReturnRector/Fixture/implicit_null_return.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Aug 10, 2025
...tests/Php85/Rector/MethodCall/NullDebugInfoReturnRector/Fixture/explicit_null_return.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Aug 10, 2025
...tests/Php85/Rector/MethodCall/NullDebugInfoReturnRector/Fixture/explicit_null_return.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Aug 10, 2025
...tests/Php85/Rector/MethodCall/NullDebugInfoReturnRector/Fixture/explicit_null_return.php.inc
Outdated
Show resolved
Hide resolved
f0b15f8 to
a08df1c
Compare
Contributor
Author
|
@samsonasik I adjusted every point. |
samsonasik
reviewed
Aug 10, 2025
...ests/Php85/Rector/MethodCall/NullDebugInfoReturnRector/Fixture/skip_different_method.php.inc
Outdated
Show resolved
Hide resolved
a08df1c to
e2cbed5
Compare
Member
|
@mttsch Could you rebase this one? Ideally keep new commits without force-push, to it's easier to review and see new changes in git history. |
samsonasik
approved these changes
Aug 11, 2025
Member
|
Thank you @mttsch |
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.