feat: add RemoveReadonlyPropertyVisibilityOnReadonlyClassRector #7115
Conversation
|
Hey, good work 👌 Last step is to register rule in the set: And apply on the codebase. Let's see what it finds here :) |
|
Sounds good---is there any preference on where the rule is added in the set? Are rules just appended or should it go near the front since it's relatively safe? |
ed995fe to
341f25b
Compare
|
Anywhere where you'd expect it. Rebase and force push make it harder for me to review new changes. Ideally keep new changes in separated commits. |
|
Should be good to go then, I ran the rector and it didn't find any instances in this codebase
I'll try to keep this in mind, but Github offers a quick way to review the interdiff: 
|
rules/CodeQuality/Rector/Class_/RemoveReadonlyPropertyVisibilityOnReadonlyClassRector.php
Show resolved
Hide resolved
rules/CodeQuality/Rector/Class_/RemoveReadonlyPropertyVisibilityOnReadonlyClassRector.php
Outdated
Show resolved
Hide resolved
rules/CodeQuality/Rector/Class_/RemoveReadonlyPropertyVisibilityOnReadonlyClassRector.php
Show resolved
Hide resolved
341f25b to
2c77a94
Compare
This Rector removes the `readonly` visibility modifier from properties in classes that are already marked as `readonly`. This is useful for cleaning up code where the `readonly` modifier is redundant due to the class's readonly status.
2c77a94 to
48d3b5c
Compare
|
Let's give it a try, thank you @calebdw |
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
Hello!
This Rector removes the
readonlyvisibility modifier from properties in classes that are already marked asreadonly. This is useful for cleaning up code where thereadonlymodifier is redundant due to the class's readonly status.Thanks!