[Php81] added `RemoveReflectionSetAccessibleCallsRector` #7085

NickSdot · 2025-07-23T03:00:07Z

As of PHP 8.1.0, calling Reflection*::setAccessible() has no effect; all properties are accessible by default. Currently, there is a RFC which proposes to issue a deprecation warning starting with Php 8.5.

Note:
I added it to the 8.5 rules, because it will likely be decprecated by then. Alternatively, we could add it to the 8.1 rules. Let me know if you think this would be more sensible.

samsonasik · 2025-07-23T03:42:35Z

You may need to install gpatch and register to path, see troubleshooting note

https://github.com/symplify/vendor-patches/?tab=readme-ov-file#troubleshooting

TomasVotruba · 2025-07-23T06:25:28Z

Thanks for the rule. Targeting 8.1 would be better, as we add rules as soon the change appears in PHP.

samsonasik · 2025-07-23T07:13:47Z

@TomasVotruba there is no "deprecation" warning on php 8.1, it just have no effect, see https://3v4l.org/ukI3N#v8.1.33

For note: downgrade to php 8.0 rule is needed for it, to add:

if (PHP_VERSION_ID <=80100) {
    $r->setAccessible(true);
}

to avoid error on downgrade upgraded code, see https://3v4l.org/ukI3N#v8.0.30

TomasVotruba · 2025-07-23T07:23:36Z

@samsonasik Exactly, it's no longer required. That's why it should be in 8.1 as a dead code

NickSdot · 2025-07-23T07:25:22Z

Thanks for the rule. Targeting 8.1 would be better, as we add rules as soon the change appears in PHP.

@TomasVotruba That's done.

TomasVotruba there is no "deprecation" warning on php 8.1, it just have no effect, see https://3v4l.org/ukI3N#v8.1.33

@samsonasik That's correct. However, to have the calls in >=8.1 is useless either way

samsonasik · 2025-07-23T07:36:58Z

We have setAccessible call in rector-src code:

rector-src/src/Util/Reflection/PrivatesAccessor.php

Line 50 in fe319d7

$reflectionProperty->setAccessible(true);

If bin/rector executed, that will be removed, then downgrade will error on php 7.4 scoped, the downgrade rule needs to cover this first at

https://github.com/rectorphp/rector-downgrade-php/tree/main/rules/DowngradePhp80

Then register at

https://github.com/rectorphp/rector-downgrade-php/blob/main/config/set/downgrade-php80.php

NickSdot · 2025-07-23T07:55:12Z

We have setAccessible call in rector-src code:

rector-src/src/Util/Reflection/PrivatesAccessor.php

Line 50 in fe319d7

$reflectionProperty->setAccessible(true);

If bin/rector executed, that will be removed, then downgrade will error on php 7.4 scoped, the downgrade rule needs to cover this first at

https://github.com/rectorphp/rector-downgrade-php/tree/main/rules/DowngradePhp80

Then register at

https://github.com/rectorphp/rector-downgrade-php/blob/main/config/set/downgrade-php80.php

@samsonasik, I never looked into downgrade rules. I assume it must also cover situations where no upgrade rule was run, and where the $reflectionProperty->setAccessible(true); is already present. I have no idea how to avoid duplication in such situations. Can you think of an existing rule that does something similar? I could try to come up with a PR in the downgrade rules repo if I have an example to orient myself.

TomasVotruba · 2025-07-23T08:14:55Z

I think we have this covered in PHP 8.1 downgrade set:
https://github.com/rectorphp/rector-downgrade-php/blob/main/config/set/downgrade-php81.php#L19

I made sure it works 👍 rectorphp/rector-downgrade-php#155

samsonasik · 2025-07-23T08:21:42Z

@TomasVotruba thank you for verify

@NickSdot could you try run:

bin/rector

then ensure this line removed

rector-src/src/Util/Reflection/PrivatesAccessor.php

Line 50 in fe319d7

$reflectionProperty->setAccessible(true);

then, we can merge to see if it can be downgraded correctly, thank you.

samsonasik · 2025-07-23T08:36:08Z

@TomasVotruba the downgrade rule only handle ReflectionProperty, but not ReflectionMethod, I will add that first ...

NickSdot · 2025-07-23T08:36:59Z

@TomasVotruba thank you for verify

@NickSdot could you try run:
bin/rector
then ensure this line removed

rector-src/src/Util/Reflection/PrivatesAccessor.php

Line 50 in fe319d7

$reflectionProperty->setAccessible(true);

then, we can merge to see if it can be downgraded correctly, thank you.

@samsonasik, yep, that works. There are more than one call of it.

Subject: [PATCH] chore: ran rector
---
Index: src/Util/Reflection/PrivatesAccessor.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/src/Util/Reflection/PrivatesAccessor.php b/src/Util/Reflection/PrivatesAccessor.php
--- a/src/Util/Reflection/PrivatesAccessor.php	(revision 5b59464b0a17c34b1f492898660e25cedb02841b)
+++ b/src/Util/Reflection/PrivatesAccessor.php	(date 1753259388951)
@@ -47,7 +47,6 @@
     public function getPrivateProperty(object $object, string $propertyName): mixed
     {
         $reflectionProperty = $this->resolvePropertyReflection($object, $propertyName);
-        $reflectionProperty->setAccessible(true);
 
         return $reflectionProperty->getValue($object);
     }
@@ -55,17 +54,13 @@
     public function setPrivateProperty(object $object, string $propertyName, mixed $value): void
     {
         $reflectionProperty = $this->resolvePropertyReflection($object, $propertyName);
-        $reflectionProperty->setAccessible(true);
 
         $reflectionProperty->setValue($object, $value);
     }
 
     private function createAccessibleMethodReflection(object $object, string $methodName): ReflectionMethod
     {
-        $reflectionMethod = new ReflectionMethod($object, $methodName);
-        $reflectionMethod->setAccessible(true);
-
-        return $reflectionMethod;
+        return new ReflectionMethod($object, $methodName);
     }
 
     private function resolvePropertyReflection(object $object, string $propertyName): ReflectionProperty

There are also some formatting changes that composer complete-check didn't report. Is this something you want me to commit or not?

Subject: [PATCH] chore: ran rector
---
Index: rules/Php81/Rector/MethodCall/RemoveReflectionSetAccessibleCallsRector.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/rules/Php81/Rector/MethodCall/RemoveReflectionSetAccessibleCallsRector.php b/rules/Php81/Rector/MethodCall/RemoveReflectionSetAccessibleCallsRector.php
--- a/rules/Php81/Rector/MethodCall/RemoveReflectionSetAccessibleCallsRector.php	(revision 5b59464b0a17c34b1f492898660e25cedb02841b)
+++ b/rules/Php81/Rector/MethodCall/RemoveReflectionSetAccessibleCallsRector.php	(date 1753259379572)
@@ -47,8 +47,8 @@
             return null;
         }
 
-        if ($this->isObjectType($methodCall->var, new ObjectType('ReflectionProperty')) === true
-            || $this->isObjectType($methodCall->var, new ObjectType('ReflectionMethod')) === true
+        if ($this->isObjectType($methodCall->var, new ObjectType('ReflectionProperty'))
+            || $this->isObjectType($methodCall->var, new ObjectType('ReflectionMethod'))
         ) {
             return NodeVisitor::REMOVE_NODE;
         }
Index: rules-tests/Php81/Rector/MethodCall/RemoveReflectionSetAccessibleCallsRector/RemoveReflectionSetAccessibleCallsRectorTest.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/rules-tests/Php81/Rector/MethodCall/RemoveReflectionSetAccessibleCallsRector/RemoveReflectionSetAccessibleCallsRectorTest.php b/rules-tests/Php81/Rector/MethodCall/RemoveReflectionSetAccessibleCallsRector/RemoveReflectionSetAccessibleCallsRectorTest.php
--- a/rules-tests/Php81/Rector/MethodCall/RemoveReflectionSetAccessibleCallsRector/RemoveReflectionSetAccessibleCallsRectorTest.php	(revision 5b59464b0a17c34b1f492898660e25cedb02841b)
+++ b/rules-tests/Php81/Rector/MethodCall/RemoveReflectionSetAccessibleCallsRector/RemoveReflectionSetAccessibleCallsRectorTest.php	(date 1753259374024)
@@ -4,6 +4,7 @@
 
 namespace Rector\Tests\Php81\Rector\MethodCall\RemoveReflectionSetAccessibleCallsRector;
 
+use Iterator;
 use PHPUnit\Framework\Attributes\DataProvider;
 use Rector\Testing\PHPUnit\AbstractRectorTestCase;
 
@@ -16,9 +17,9 @@
     }
 
     /**
-     * @return \Iterator<array<string>>
+     * @return Iterator<array<string>>
      */
-    public static function provideData(): \Iterator
+    public static function provideData(): Iterator
     {
         return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
     }

samsonasik · 2025-07-23T08:43:36Z

@NickSdot thank you, I created PR to allow downgrade ReflectionMethod as well:

[DowngradePhp81] Allow downgrade ReflectionMethod on DowngradeSetAccessibleReflectionPropertyRector rector-downgrade-php#296

NickSdot · 2025-07-23T08:46:11Z

Two questions:

Is the location rules/Php81 ok now or should it be rules/DeadCode
Do we need to add this rule to config/set/dead-code.php?

samsonasik · 2025-07-23T08:47:44Z

@NickSdot I've just ability to downgrade ReflectionMethod

[DowngradePhp81] Allow downgrade ReflectionMethod on DowngradeSetAccessibleReflectionPropertyRector rector-downgrade-php#296

On php81 set is ok for this :)

@NickSdot could you run and commit the change for it so we can test downgrade is working? Thank you.

bin/rector
git commit -a

NickSdot · 2025-07-23T08:52:28Z

@samsonasik committed and pushed.

FYI: composer check-cs and bin/rector clash in ClosureFromCallableToFirstClassCallableRector.php

samsonasik · 2025-07-23T08:52:54Z

It seems you need to rebase latest main

samsonasik · 2025-07-23T08:56:50Z

src/Util/Reflection/PrivatesAccessor.php

-        $reflectionMethod->setAccessible(true);
-
-        return $reflectionMethod;
+        return new ReflectionMethod($object, $methodName);


the downgrade rule seems not handling on return yet, only Expression, I will look into it.

Side note: DowngradeSetAccessibleReflectionPropertyRector has "Property" in the name. Your last PR rectorphp/rector-downgrade-php#296 added handling for methods. Just pointing it out in case that's relevant.

that isNames() for :)

if (! $this->isNames($new->class, ['ReflectionProperty', 'ReflectionMethod'])) {

I created PR to handle on direct return

[DowngradePhp81] Handle on return on DowngradeSetAccessibleReflectionPropertyRector rector-downgrade-php#297

Yeah, I just meant that the rule name now no longer exactly fits to what the rule does.

Yeah, that can be refactored next (if needed :) ), but we need to ensure downgrade working first :)

samsonasik · 2025-07-23T09:20:37Z

Okay, preparation is done for our use cases :), @TomasVotruba let's merge.

Thank you @NickSdot

NickSdot · 2025-07-23T09:30:47Z

That was fun! 🤝

samsonasik · 2025-07-23T09:31:00Z

It seems downgraded correctly

rectorphp/rector@415cc1a#diff-aa4acc8abf2aa549804bc88f2b13eb203d8a18dd8f8a6e9db9289038a4ab1a2d

On resolvePropertyReflection next statement is removed setAccessible(true), but on method resolvePropertyReflection() itself, the setAccessible(true) already added, so it seems safe :)

github-actions · 2025-12-21T03:32:43Z

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

NickSdot force-pushed the feat/remove-setAccessible-rector branch 3 times, most recently from 4087338 to 2d84438 Compare July 23, 2025 03:34

This comment was marked as resolved.

Sign in to view

NickSdot changed the title ~~[Php85] added RemoveDeprecatedReflectionSetAccessibleCallsRector~~ [Php85] added RemoveReflectionSetAccessibleCallsRector Jul 23, 2025

This comment has been minimized.

Sign in to view

NickSdot force-pushed the feat/remove-setAccessible-rector branch from 2d84438 to 84deedb Compare July 23, 2025 07:17

feat: added RemoveDeprecatedReflectionSetAccessibleCallsRector

5b59464

NickSdot force-pushed the feat/remove-setAccessible-rector branch from 84deedb to 5b59464 Compare July 23, 2025 07:30

samsonasik changed the title ~~[Php85] added RemoveReflectionSetAccessibleCallsRector~~ [Php81] added RemoveReflectionSetAccessibleCallsRector Jul 23, 2025

samsonasik mentioned this pull request Jul 23, 2025

[DowngradePhp81] Allow downgrade ReflectionMethod on DowngradeSetAccessibleReflectionPropertyRector rectorphp/rector-downgrade-php#296

Merged

chore: ran rector in preparation for downgrade testing

4ed3b10

Merge branch 'main' into feat/remove-setAccessible-rector

7b4393c

samsonasik reviewed Jul 23, 2025

View reviewed changes

samsonasik mentioned this pull request Jul 23, 2025

[DowngradePhp81] Handle on return on DowngradeSetAccessibleReflectionPropertyRector rectorphp/rector-downgrade-php#297

Merged

samsonasik merged commit 6d046c1 into rectorphp:main Jul 23, 2025
47 checks passed

NickSdot deleted the feat/remove-setAccessible-rector branch July 23, 2025 09:31

github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2025

Uh oh!

[Php81] added RemoveReflectionSetAccessibleCallsRector #7085

[Php81] added RemoveReflectionSetAccessibleCallsRector #7085

Uh oh!

Conversation

NickSdot commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

samsonasik commented Jul 23, 2025

Uh oh!

This comment has been minimized.

TomasVotruba commented Jul 23, 2025

Uh oh!

samsonasik commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TomasVotruba commented Jul 23, 2025

Uh oh!

NickSdot commented Jul 23, 2025

Uh oh!

samsonasik commented Jul 23, 2025

Uh oh!

NickSdot commented Jul 23, 2025

Uh oh!

TomasVotruba commented Jul 23, 2025

Uh oh!

samsonasik commented Jul 23, 2025

Uh oh!

samsonasik commented Jul 23, 2025

Uh oh!

NickSdot commented Jul 23, 2025

Uh oh!

samsonasik commented Jul 23, 2025

Uh oh!

NickSdot commented Jul 23, 2025

Uh oh!

samsonasik commented Jul 23, 2025

Uh oh!

NickSdot commented Jul 23, 2025

Uh oh!

samsonasik commented Jul 23, 2025

Uh oh!

samsonasik Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

NickSdot Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

samsonasik Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

samsonasik Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

NickSdot Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

samsonasik Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

samsonasik commented Jul 23, 2025

Uh oh!

Uh oh!

NickSdot commented Jul 23, 2025

Uh oh!

samsonasik commented Jul 23, 2025

Uh oh!

github-actions bot commented Dec 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[Php81] added `RemoveReflectionSetAccessibleCallsRector` #7085

[Php81] added `RemoveReflectionSetAccessibleCallsRector` #7085

NickSdot commented Jul 23, 2025 •

edited

Loading

samsonasik commented Jul 23, 2025 •

edited

Loading