Skip to content

Conversation

@samsonasik
Copy link
Member

@gharlan @TomasVotruba continue of PR:

When no files changed, early return empty on FilesFinder, even on kaizen, because nothing to process anymore, if there is change, then on kaizen, it probably other change as well.

Screenshot 2025-07-08 at 04 01 34

@samsonasik
Copy link
Member Author

@TomasVotruba let's merge to have faster feedback to test ;)

@samsonasik samsonasik merged commit 6670b90 into main Jul 7, 2025
47 checks passed
@samsonasik samsonasik deleted the no-change-kaizen branch July 7, 2025 21:04
@samsonasik
Copy link
Member Author

samsonasik commented Jul 7, 2025

@gharlan please first clear cache, then run normally after that:

# first required for this change, scans 747 files, change 16 files
vendor/bin/rector --kaizen 1 --clear-cache

# scans 747 files again because there was a 16 files changed on previous run, so probablay there is other next rule to apply
vendor/bin/rector --kaizen 1

@gharlan
Copy link

gharlan commented Jul 7, 2025

Thanks!

The second run is indeed scanning all 747 files again, but it does not apply any rule, so no changes.
(When doing a third run with --clear-cache, the next rule is applied)

@samsonasik
Copy link
Member Author

I see, it may rely on cache invalidation, so force clear cache is needed before returned when there is file change + kaizen, I will check...

@samsonasik
Copy link
Member Author

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants