Skip to content

Conversation

@xHeaven
Copy link
Contributor

@xHeaven xHeaven commented Jun 21, 2025

No description provided.

@TomasVotruba
Copy link
Member

Thanks 👍 Could you rebase this one on latest main?

@xHeaven
Copy link
Contributor Author

xHeaven commented Jun 21, 2025

Thanks 👍 Could you rebase this one on latest main?

Absolutely, it'll be done in an hour when I'm back at the PC :)

@xHeaven
Copy link
Contributor Author

xHeaven commented Jun 21, 2025

@TomasVotruba Should be done. I assume the other PR will also conflict, will do that too after you merged this one.

@TomasVotruba
Copy link
Member

Thanks 👍 I was able to handle 1 conflicts via GUI here. All good 🙏

@TomasVotruba TomasVotruba enabled auto-merge (squash) June 21, 2025 22:48
auto-merge was automatically disabled June 21, 2025 22:48

Head branch was pushed to by a user without write access

@xHeaven
Copy link
Contributor Author

xHeaven commented Jun 21, 2025

Thanks 👍 I was able to handle 1 conflicts via GUI here. All good 🙏

Whoops, I also did the handywork :D All should be good, though.

@TomasVotruba TomasVotruba merged commit dc677e1 into rectorphp:main Jun 21, 2025
45 checks passed
@TomasVotruba
Copy link
Member

Even better :) thanks 👍

Feel free to send next bunch of similar PRs together. You code was very well done

@xHeaven
Copy link
Contributor Author

xHeaven commented Jun 21, 2025

Even better :) thanks 👍

Feel free to send next bunch of similar PRs together. You code was very well done

Appreciate it! And will do, just wasn't sure if you'd prefer a bigger PR or smaller ones per feature, so I played safe. :)

@github-actions
Copy link
Contributor

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants