[DeadCode] Covers scenario where func_get_args used in constructor for RemoveUnusedConstructorParamRector #7006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Nice one, thank you 👍 |
samsonasik
reviewed
Jun 22, 2025
| return $this->nodeNameResolver->isNames($param, $arguments); | ||
| } | ||
|
|
||
| private function isFuncGetArgsCall(Node $node): bool |
Member
There was a problem hiding this comment.
this should can use VariadicFunctionLikeDetector::isVariadic() that cover 3 functions:
- func_get_arg
- func_get_args
- func_num_args
Member
There was a problem hiding this comment.
I created PR for it:
to merge functionality into ParamAnalyzer and remove the VariadicFunctionLikeDetector as double work and cause manually called.
3 tasks
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
func_get_argswithin a methodfunc_get_argsWhy
I found this issue popping up if
func_get_argswas used in a constructor. In theory there's alsofunc_get_arg(int position)to consider as well but it's a question of either:func_get_arg()as well