[DeadCode] Fix: Array Duplicated Key which is dynamic #6999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
approved these changes
Jun 18, 2025
Member
|
Thank you Peter 🙂 |
samsonasik
reviewed
Jun 19, 2025
Comment on lines
+99
to
+105
| if ($arrayItem->key instanceof CallLike) { | ||
| continue; | ||
| } | ||
|
|
||
| if ($arrayItem->key instanceof PropertyFetch) { | ||
| continue; | ||
| } |
Member
There was a problem hiding this comment.
this should use ExprAnalyzer->isDynamicExpr()
Member
There was a problem hiding this comment.
I created PR for it, with additional fixture test:
samsonasik
reviewed
Jun 19, 2025
|
|
||
| namespace Rector\Tests\DeadCode\Rector\Array_\RemoveDuplicatedArrayKeyRector\Fixture; | ||
|
|
||
| class SkipMethodAndFunctCalls |
Member
There was a problem hiding this comment.
Suggested change
| class SkipMethodAndFunctCalls | |
| class SkipPropertyFetch |
samsonasik
reviewed
Jun 19, 2025
|
|
||
| namespace Rector\Tests\DeadCode\Rector\Array_\RemoveDuplicatedArrayKeyRector\Fixture; | ||
|
|
||
| class SkipMethodAndFunctCalls |
Member
There was a problem hiding this comment.
Suggested change
| class SkipMethodAndFunctCalls | |
| class SkipCallLikeKeys |
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Why
I found this dead code rule could end up removing array keys if the key was set by a method call, function call or a property fetch that might be dynamic. There might be a way to allow these options back by using PHPStan to look for constant values returned by the dynamic call but for now I think it best to just exclude them so the rule is less likely to remove intended user code.