Skip to content

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Jun 18, 2025

non abstract method trait signature can different: https://3v4l.org/bgNqZ
abstract one must follow: https://3v4l.org/2B6F8

Fixes rectorphp/rector#9223

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @sbdfh

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik changed the title [Php80] Skip override non-abstract method trait on AddParamBasedOnParentClassMethodRector [Php80] Skip non-abstract method trait on AddParamBasedOnParentClassMethodRector Jun 18, 2025
@samsonasik samsonasik merged commit de99ff2 into main Jun 18, 2025
44 of 45 checks passed
@samsonasik samsonasik deleted the skip-override-non-abstract-tarit branch June 18, 2025 03:28
@github-actions
Copy link
Contributor

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect behavior of AddParamBasedOnParentClassMethodRector

2 participants