Skip to content

[Php80] Handle has silent void on StringableForToStringRector #6970

Merged
samsonasik merged 4 commits intomainfrom
silent-void
Jun 10, 2025
Merged

[Php80] Handle has silent void on StringableForToStringRector #6970
samsonasik merged 4 commits intomainfrom
silent-void

Conversation

@samsonasik
Copy link
Copy Markdown
Member

    public function __toString()
    {
        if (rand(0, 1)) {
            return 'something';
        }
    }

should add return '' on last root return:

        if (rand(0, 1)) {
            return 'something';
        }
+      return '';

@samsonasik
Copy link
Copy Markdown
Member Author

All checks have passed 🎉 @TomasVotruba I am merging ;)

@samsonasik samsonasik merged commit 0c91a0f into main Jun 10, 2025
45 checks passed
@samsonasik samsonasik deleted the silent-void branch June 10, 2025 03:23
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant