Skip to content

[Command] Fix to make additionalAutoloader->autoloadPaths() works on both parallel and non-parallel proccess #6927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samsonasik merged 1 commit into from
May 25, 2025
Merged

[Command] Fix to make additionalAutoloader->autoloadPaths() works on both parallel and non-parallel proccess #6927

samsonasik merged 1 commit into from
May 25, 2025

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented May 25, 2025

This patch is variant version of PR for autoloadPaths() from config.

Do the followings:

  • ensure additionalAutoloader->autoloadPaths() called after $this->dynamicSourceLocatorDecorator->arePathsEmpty() on ProcessCommand

rector-src/src/Console/Command/ProcessCommand.php

Line 120 in 7feb6c8

if ($this->dynamicSourceLocatorDecorator->arePathsEmpty()) {

since it register to DynamicSourceLocatorProvider via

rector-src/src/Autoloading/AdditionalAutoloader.php

Lines 40 to 44 in 7feb6c8

public function autoloadPaths(): void
{
$autoloadPaths = SimpleParameterProvider::provideArrayParameter(Option::AUTOLOAD_PATHS);
$this->dynamicSourceLocatorDecorator->addPaths($autoloadPaths);
}

  • make run it on parallel as well, since it different process on its own

@samsonasik
Copy link
Member Author

samsonasik commented May 25, 2025

/cc @marcelthole @boesing @staabm FYI

@samsonasik
Copy link
Member Author

samsonasik commented May 25, 2025

All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;)

@samsonasik samsonasik merged commit 5d1b2c6 into main May 25, 2025
45 checks passed
@samsonasik samsonasik deleted the on-parallel branch May 25, 2025 12:44
@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2025

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samsonasik