Skip to content

[Command] Fix to make additionalAutoloader->autoloadPaths() works on both parallel and non-parallel proccess#6927

Merged
samsonasik merged 1 commit intomainfrom
on-parallel
May 25, 2025
Merged

[Command] Fix to make additionalAutoloader->autoloadPaths() works on both parallel and non-parallel proccess#6927
samsonasik merged 1 commit intomainfrom
on-parallel

Conversation

@samsonasik
Copy link
Copy Markdown
Member

This patch is variant version of PR for autoloadPaths() from config.

Do the followings:

  • ensure additionalAutoloader->autoloadPaths() called after $this->dynamicSourceLocatorDecorator->arePathsEmpty() on ProcessCommand

if ($this->dynamicSourceLocatorDecorator->arePathsEmpty()) {

since it register to DynamicSourceLocatorProvider via

public function autoloadPaths(): void
{
$autoloadPaths = SimpleParameterProvider::provideArrayParameter(Option::AUTOLOAD_PATHS);
$this->dynamicSourceLocatorDecorator->addPaths($autoloadPaths);
}

  • make run it on parallel as well, since it different process on its own

@samsonasik
Copy link
Copy Markdown
Member Author

/cc @marcelthole @boesing @staabm FYI

@samsonasik
Copy link
Copy Markdown
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;)

@samsonasik samsonasik merged commit 5d1b2c6 into main May 25, 2025
45 checks passed
@samsonasik samsonasik deleted the on-parallel branch May 25, 2025 12:44
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant