Skip to content

[Test] Add test for crash after reprint Stmt #6924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samsonasik merged 1 commit into from
May 24, 2025
Merged

[Test] Add test for crash after reprint Stmt #6924

samsonasik merged 1 commit into from
May 24, 2025

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented May 24, 2025 •
edited
Loading

This add test for RectifiedAnalyzer::isJustReprintedOverlappedTokenStart() on no scope after re-print due to seems phpstan can't detect reprinted stmt:

rector-src/src/ProcessAnalyzer/RectifiedAnalyzer.php

Line 85 in 9f3665a

return ! in_array(AttributeKey::SCOPE, array_keys($node->getAttributes()), true);

if the check removed, the code got error:

There was 1 error:

1) Rector\Tests\Issues\ChangeSwitchTernary\ChangeSwitchTernaryTest::test with data set #0 ('/Users/samsonasik/www/rector-...hp.inc')
Rector\Exception\ShouldNotHappenException: Scope not available on "PhpParser\Node\Stmt\Expression" node. Fix scope refresh on changed nodes first

This test ensure the code in place tested in place.

@samsonasik
Copy link
Member Author

samsonasik commented May 24, 2025

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 00da8f3 into main May 24, 2025
45 checks passed
@samsonasik samsonasik deleted the add-test-crash branch May 24, 2025 14:18
@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2025

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samsonasik