Skip to content

[PHP84] Deprecated annotation to Deprecated attribute #6923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TomasVotruba merged 11 commits into from
May 28, 2025
Merged

[PHP84] Deprecated annotation to Deprecated attribute #6923

TomasVotruba merged 11 commits into from
May 28, 2025

Conversation

@peterfox
Copy link
Contributor

@peterfox peterfox commented May 23, 2025

Changes

  • Adds a new DeprecatedAnnotationToDeprecatedAttributeRector rule
  • Adds tests for DeprecatedAnnotationToDeprecatedAttributeRector
  • Adds DeprecatedAnnotationToDeprecatedAttributeRector to the PHP 84 config
  • Adds the DEPRECATED_ATTRIBUTE constant

Why

Pretty self explanatory. This just moves the annotation to an attribute as is the case for a lot of things in the PHP world now. The attribute was added in PHP 8.4.

-/**
-* @deprecated 1.0.0 Use SomeOtherClass instead
-*/
+#[\Deprecated(message: 'Use SomeOtherClass instead', since: 1.0.0)]
class SomeClass
{
}

@TomasVotruba
Copy link
Member

TomasVotruba commented May 23, 2025 •
edited
Loading

Thanks Peter 👍

How is the attribute supporting doing in PHPStan https://github.com/phpstan/phpstan-deprecation-rules ?
How's the PHPStorm support for in-code feedback?

We don't want to break those 2, as that's the main benefit of @deprecated in the code.

@peterfox
Copy link
Contributor Author

peterfox commented May 24, 2025

Thanks Peter 👍

How is the attribute supporting doing in PHPStan https://github.com/phpstan/phpstan-deprecation-rules ? How's the PHPStorm support for in-code feedback?

We don't want to break those 2, as that's the main benefit of @deprecated in the code.

@TomasVotruba it appears I got a head of myself 😓 PHPStan doesn't seem to support it, nor does PHPStorm.

Equally only till testing it more did I realise that the attribute only works with Functions/Class Methods/Constants, so it's a bit poor compared to the annotation.

Happy to shelve this PR until the attribute is more useful.

peterfox and others added 2 commits May 25, 2025 13:55
@peterfox @samsonasik
Update rules/Php84/Rector/Class_/DeprecatedAnnotationToDeprecatedAttr…
fe65d0f 
…ibuteRector.php

Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
@peterfox
fixes
0f6e0ca
@peterfox peterfox requested a review from samsonasik May 28, 2025 20:45
@TomasVotruba TomasVotruba merged commit 8874702 into rectorphp:main May 28, 2025
45 checks passed
@TomasVotruba
Copy link
Member

TomasVotruba commented May 28, 2025 •
edited
Loading

Thank you Peter 🥳 Let's ship it

@VincentLanglet VincentLanglet mentioned this pull request Jun 30, 2025
Closed
DanielEScherzer added a commit to DanielEScherzer/rector-src that referenced this pull request Aug 20, 2025
@DanielEScherzer
[PHP 8.5] Convert @deprecated to #[\Deprecated] on constants
c46b62b 
Based on the PHP 8.4 rule from rectorphp#6923
@DanielEScherzer DanielEScherzer mentioned this pull request Aug 20, 2025
Merged
DanielEScherzer added a commit to DanielEScherzer/rector-src that referenced this pull request Aug 20, 2025
@DanielEScherzer
[PHP 8.5] Convert @deprecated to #[\Deprecated] on constants
251b70b 
Based on the PHP 8.4 rule from rectorphp#6923
DanielEScherzer added a commit to DanielEScherzer/rector-src that referenced this pull request Aug 20, 2025
@DanielEScherzer
[PHP 8.5] Convert @deprecated to #[\Deprecated] on constants
3ba04e4 
Based on the PHP 8.4 rule from rectorphp#6923, logic was moved to a new
`DeprecatedAnnotationToDeprecatedAttributeConverter` service to avoid
duplication.
DanielEScherzer added a commit to DanielEScherzer/rector-src that referenced this pull request Aug 20, 2025
@DanielEScherzer
[PHP 8.5] Convert @deprecated to #[\Deprecated] on constants
650867f 
Based on the PHP 8.4 rule from rectorphp#6923, logic was moved to a new
`DeprecatedAnnotationToDeprecatedAttributeConverter` service to avoid
duplication.
samsonasik pushed a commit that referenced this pull request Aug 20, 2025
@DanielEScherzer
[PHP 8.5] Convert @deprecated to #[\Deprecated] on constants (#7155)
c5876ad 
Based on the PHP 8.4 rule from #6923, logic was moved to a new
`DeprecatedAnnotationToDeprecatedAttributeConverter` service to avoid
duplication.
@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@samsonasik samsonasik Awaiting requested review from samsonasik

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@peterfox @TomasVotruba @samsonasik