Skip to content

Conversation

@simonschaufi
Copy link
Contributor

No description provided.

@simonschaufi
Copy link
Contributor Author

Looking at the source code, I ask myself what this has to do with PHPUnit

@samsonasik
Copy link
Member

Thank you @simonschaufi , it seems was copy paste from phpunit rules.

@samsonasik samsonasik merged commit 7db2d51 into rectorphp:main May 18, 2025
45 checks passed
@simonschaufi
Copy link
Contributor Author

One question: how and when is the documentation here https://getrector.com/find-rule?query=RemoveUselessReturnTagRector rendered again?

@simonschaufi simonschaufi deleted the use-active-voice branch May 18, 2025 21:25
@simonschaufi
Copy link
Contributor Author

oh and can you please adjust in the repo settings that the HEAD branch get's deleted after a merge? That would be great!

@samsonasik
Copy link
Member

samsonasik commented May 18, 2025

The web is deployed per 06.30 and 00.30 daily iirc, I am on mobile now, should be next 3 or 4 hours.

we were try to not use squash on merge, but cause issues on us due to auto commit and build usage iirc, so we back to squash on merge again.

@simonschaufi
Copy link
Contributor Author

Ok, good to know.

I'm not talking about the merge strategy but that my PR branch get's deleted after merge. This can only be set in the repo settings.

@samsonasik
Copy link
Member

Oh, I don't have admin access for that, @TomasVotruba should be able to set that

@samsonasik
Copy link
Member

about auto remove PR branch, probably on purpose due to auto PR weekly so it keep sync

@github-actions
Copy link
Contributor

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants