Skip to content

[Config] Handle config realpath() actually has asterisk, not pattern #6891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samsonasik merged 1 commit into from
May 10, 2025
Merged

[Config] Handle config realpath() actually has asterisk, not pattern #6891

samsonasik merged 1 commit into from
May 10, 2025

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented May 10, 2025 •
edited
Loading

Ref rectorphp/rector#9156 (comment)
Fixes rectorphp/rector#9156

with directory structure:

➜  ~ tree -L 2 com.example.\* 

com.example.*
└── some-other
    └── projectdir

Before

➜  projectdir vendor/bin/rector
                                                                                                                   
 [ERROR] Matching file paths by using glob-patterns is no longer supported. Use specific file path instead.

After

➜  projectdir vendor/bin/rector 
 1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

                                                                                                                        
 [OK] Rector is done!

Reproduced on macOS

@samsonasik
Copy link
Member Author

samsonasik commented May 10, 2025

Fixed 🎉 /cc @PhilippeDunbar

@samsonasik
Copy link
Member Author

samsonasik commented May 10, 2025

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 2c73f6a into main May 10, 2025
45 checks passed
@samsonasik samsonasik deleted the handle-with-asterisk branch May 10, 2025 23:33
@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2025

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Edge Case: Literal asterisk in project's parent directory throws glob error

2 participants

@samsonasik