feat: handle edge cases of DateFuncCallToCarbonRector#6822
Merged
TomasVotruba merged 6 commits intorectorphp:mainfrom Apr 23, 2025
Merged
feat: handle edge cases of DateFuncCallToCarbonRector#6822TomasVotruba merged 6 commits intorectorphp:mainfrom
TomasVotruba merged 6 commits intorectorphp:mainfrom
Conversation
Member
|
/cc @melbings @kylekatarnls @gollumeo |
Member
|
I've reviewed briefly and it looks good to me. Let's ship this to verify in real-life projects. Thank you for contribution @tony-stark-eth 👏 |
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After applying the carbon rules to a legacy project, I noticed some shortcomings.
Please rather see this a draft than a finished contribution, would be open for discussion :)
If desired I can fix the history later.