[CodeQuality] Skip unused static methods in LocallyCalledStaticMethodToNonStaticRector, as should be handled by another rule#6731
Conversation
73ce5a6 to
3c20bd8
Compare
…ToNonStaticRector, as should be handled by another rule
8ebdbd7 to
27e0fd8
Compare
| { | ||
| public static function run() | ||
| { | ||
| $result = self::anotherStatic(); |
There was a problem hiding this comment.
the self::anotherStatic() one should be processed, as it called, that mean it is used, the verification seems on current method over the caller one.
I will check on it.
There was a problem hiding this comment.
It should not, as this method is static
There was a problem hiding this comment.
ok, it skipped due to run() method is static, so it seems nothing to do with commented code, I will check more in case of regression of the patch, since current class name call seems only on ['self', 'static'], which current class name for ClassName::execute() is not included.
There was a problem hiding this comment.
I create new PR for actual fixture for never called, with non-static method run()
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
No description provided.