Skip to content

[Performance] Use exactly equal or append / file path check on RealpathMatcher#6716

Merged
samsonasik merged 1 commit intomainfrom
perf-exact-equal-append
Feb 3, 2025
Merged

[Performance] Use exactly equal or append / file path check on RealpathMatcher#6716
samsonasik merged 1 commit intomainfrom
perf-exact-equal-append

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik commented Feb 3, 2025 •
edited
Loading

Remove unnecessary IO for is_file() and is_dir(), as realpath() already validated before,

rector-src/src/Skipper/RealpathMatcher.php

Lines 13 to 21 in 4f54239

$realPathMatchingPath = realpath($matchingPath);
if ($realPathMatchingPath === false) {
return false;
}
$realpathFilePath = realpath($filePath);
if ($realpathFilePath === false) {
return false;
}

so just compare string equal or append with / suffix to file path.

@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Feb 3, 2025

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 7f91068 into main Feb 3, 2025
@samsonasik samsonasik deleted the perf-exact-equal-append branch February 3, 2025 14:36
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 21, 2025

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@samsonasik