Skip to content

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Feb 3, 2025

  • Move isWindows() method from AbstractRectorTestCase to AbstractLazyTestCase
  • Make use of this repetitive usage.
  • Skip symlink tested locally on windows 11 which unreliable with use the isWindows() method

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit 4f54239 into main Feb 3, 2025
44 checks passed
@TomasVotruba
Copy link
Member

👍

@TomasVotruba TomasVotruba deleted the dx-move-is-windows branch February 3, 2025 09:25
@github-actions
Copy link
Contributor

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants