fix: NewlineBeforeNewAssignSetRector variable as same name like property #6705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Please add test fixture for it at https://github.com/rectorphp/rector-src/tree/main/rules-tests/CodingStyle/Rector/ClassMethod/NewlineBeforeNewAssignSetRector/Fixture |
Contributor
Author
Done ! |
samsonasik
reviewed
Jan 29, 2025
...ts/CodingStyle/Rector/ClassMethod/NewlineBeforeNewAssignSetRector/Fixture/properties.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Jan 29, 2025
...ts/CodingStyle/Rector/ClassMethod/NewlineBeforeNewAssignSetRector/Fixture/properties.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Jan 29, 2025
rules/CodingStyle/Rector/ClassMethod/NewlineBeforeNewAssignSetRector.php
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Jan 29, 2025
rules/CodingStyle/Rector/ClassMethod/NewlineBeforeNewAssignSetRector.php
Outdated
Show resolved
Hide resolved
d052ec1 to
798c1a8
Compare
798c1a8 to
2efbeea
Compare
Member
|
Thank you @guideloince |
Contributor
|
Did this fix this? It moved my comment into the next line:
|
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi people,
I open an issue and i try to fix.
I'm not sure for a development code 🙏
Thanks for your feedback.