[BetterPhpDocParser] Check for closing brace in text content (#8977)#6670
Merged
samsonasik merged 1 commit intorectorphp:mainfrom Jan 16, 2025
Merged
[BetterPhpDocParser] Check for closing brace in text content (#8977)#6670samsonasik merged 1 commit intorectorphp:mainfrom
samsonasik merged 1 commit intorectorphp:mainfrom
Conversation
Member
|
Wow, you've found a way to fix it! That's great Could you add test fixture from the phpunit one, so we can see if it's passing? |
b00c4f6 to
dca50bb
Compare
Contributor
Author
|
Sure thing - I've amended the commit to add this test (and confirmed it was failing before the patch). |
Member
|
Let's give it a try, thank you @andrewnicols |
Member
|
Looks great, thank you @andrewnicols 🙏 |
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a possibel fix for #8977, but it may not be the correct fix.
I feel that the bug is probably the phpstan Lexer as I would expect the closing brace to be picked up as its own token.
Dumping the regex used by the Lexer into regex101 shows that the lexer only tokenises the closing brace if there is whitespace before it, which is not necessarily the case for inline doc tags:
https://regex101.com/r/4TPY7V/2
Closes rectorphp/rector#8977