[DX] Report files with start with <?= short php tag#6075
Merged
TomasVotruba merged 9 commits intomainfrom Jun 29, 2024
Merged
Conversation
Member
Author
|
implemented 🎉 |
Member
Author
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
Contributor
|
Does the problem also happen when a short open tag is used somewhere within the file? |
Member
Author
|
It only verify content file start with for safest, as in the middle can be a string |
staabm
reviewed
Jun 29, 2024
| $filteredFilePaths, | ||
| fn (string $file): bool => ! $this->isStartWithShortPHPTag(FileSystem::read($file)) | ||
| function (string $file): bool { | ||
| if ($this->isStartWithShortPHPTag(FileSystem::read($file))) { |
Contributor
There was a problem hiding this comment.
We should have a test whether this works for files using a byte order mark (BOM)
Member
There was a problem hiding this comment.
That could be done in separate go. Care for PR? :)
Member
|
Thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@TomasVotruba @staabm here on progress to report files with start with
<?=short php tagRef #6068 (comment)
Ref https://3v4l.org/tHtB2
For direct files
For inside directory