Skip to content

[Php81] Handle usage as arg by ref key on falsy ObjectType on ReadOnlyPropertyRector#6054

Merged
TomasVotruba merged 3 commits intomainfrom
skip-pdo-bindparams
Jun 27, 2024
Merged

[Php81] Handle usage as arg by ref key on falsy ObjectType on ReadOnlyPropertyRector#6054
TomasVotruba merged 3 commits intomainfrom
skip-pdo-bindparams

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik
Copy link
Copy Markdown
Member Author

Fixed 🎉 /cc @nikolicaleksa

@samsonasik
Copy link
Copy Markdown
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit fa93e65 into main Jun 27, 2024
@TomasVotruba TomasVotruba deleted the skip-pdo-bindparams branch June 27, 2024 06:36
@TomasVotruba
Copy link
Copy Markdown
Member

Looks good, thanks 👍

@nikolicaleksa
Copy link
Copy Markdown
Contributor

Fixed 🎉 /cc @nikolicaleksa

Awesome, thanks for the fast fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReadOnlyPropertyRector not detecting when property passed by reference

4 participants