Skip to content

[Config] Exclude listed on .gitignore for withRootFiles()#6028

Merged
TomasVotruba merged 5 commits intomainfrom
exclude-listed-in-gitignore
Jun 25, 2024
Merged

[Config] Exclude listed on .gitignore for withRootFiles()#6028
TomasVotruba merged 5 commits intomainfrom
exclude-listed-in-gitignore

Conversation

@samsonasik
Copy link
Copy Markdown
Member

To avoid manually skip like in:

when withRootFiles() called.

@samsonasik
Copy link
Copy Markdown
Member Author

@TomasVotruba it is ready for review, phpstan notice on rector-* extension is unrelated.

@samsonasik samsonasik marked this pull request as draft June 25, 2024 02:48
@samsonasik samsonasik marked this pull request as ready for review June 25, 2024 02:50
@samsonasik
Copy link
Copy Markdown
Member Author

tested on getrector.com repo and it seems working ok 👍

@samsonasik samsonasik force-pushed the exclude-listed-in-gitignore branch from dff7812 to 17a5e94 Compare June 25, 2024 03:38
@samsonasik
Copy link
Copy Markdown
Member Author

Rebased 👍

@samsonasik
Copy link
Copy Markdown
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba
Copy link
Copy Markdown
Member

Looks good 😊

@TomasVotruba TomasVotruba merged commit 221aa01 into main Jun 25, 2024
@TomasVotruba TomasVotruba deleted the exclude-listed-in-gitignore branch June 25, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants