[Bc Break] [Alternative] Drop children class detection#5995
Merged
TomasVotruba merged 4 commits intomainfrom Jun 21, 2024
Merged
[Bc Break] [Alternative] Drop children class detection#5995TomasVotruba merged 4 commits intomainfrom
TomasVotruba merged 4 commits intomainfrom
Conversation
Member
Author
|
All checks have passed 🎉 @TomasVotruba you decide ;) |
Member
Author
|
Also @nuryagdym FYI |
Member
|
Thank you for fast work 👏 Let's roll |
This was referenced Jun 21, 2024
|
Thanks! My runtime is back down from 16 minutes to 2 minutes after upgrading from v1.1.0 to v1.1.1. |
Member
|
@chescos Awesome, glad to hear that 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Children class detection is usefull, but collect class may cause side effect on performance, so this PR drop it, with caveat for add return type which may cause bug when class has child.
For win-win solution, I skip add return type on abstract class.
FYI: @dorrogeray @staabm @chescos @X-Coder264 @mfn
Trade-off: back to original functionality, that cannot detect child, but set skip on add return type on abstract class which mostly overridden.
Notes:
For limit on final class, that probably needs separate PR for separate discussion, as they will need to check on param type addition rules as well.