Skip to content

[Set] Add new rector-preset set to have opiniated rector rules that can be enabled in rector-src and its extension#5924

Merged
samsonasik merged 5 commits intomainfrom
opiniated-set
May 30, 2024
Merged

[Set] Add new rector-preset set to have opiniated rector rules that can be enabled in rector-src and its extension#5924
samsonasik merged 5 commits intomainfrom
opiniated-set

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik commented May 29, 2024

Alternative of #5923
Closes #5923

…an be enabled in rector-src and its extension
@samsonasik samsonasik marked this pull request as ready for review May 29, 2024 15:19
@samsonasik
Copy link
Copy Markdown
Member Author

All checks have passed 🎉 @TomasVotruba you choose ;)

I prefer to this PR, so no need repetitive copy paste rules in rector-src and its extension for our standard so they are actually tested in real our code base.

@TomasVotruba
Copy link
Copy Markdown
Member

Looks good, just one rule to ommit and its ready 👍

@samsonasik
Copy link
Copy Markdown
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 66e5726 into main May 30, 2024
@samsonasik samsonasik deleted the opiniated-set branch May 30, 2024 07:26
@TomasVotruba
Copy link
Copy Markdown
Member

Awesome :)

@andrew-demb
Copy link
Copy Markdown
Contributor

What about adding a short description for the SetList constants?
@samsonasik

I searched the reason why I have this warning in the output:

 [WARNING] Skipped rule                                                         

           "Rector\CodingStyle\Rector\PostInc\PostIncDecToPreIncDecRector" is  never registered. You can remove it from "->withSkip()"              

In the codebase, I found that this rule is now enabled only in rector-preset, but I didn't know whether it is a new set or what the semantics of it

@samsonasik
Copy link
Copy Markdown
Member Author

@andrew-demb good idea, could you add PR for it? It basically opiniated rules that match rector coding standard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants