[Set] Add new rector-preset set to have opiniated rector rules that can be enabled in rector-src and its extension#5924
Merged
samsonasik merged 5 commits intomainfrom May 30, 2024
Merged
Conversation
…an be enabled in rector-src and its extension
Member
Author
|
All checks have passed 🎉 @TomasVotruba you choose ;) I prefer to this PR, so no need repetitive copy paste rules in rector-src and its extension for our standard so they are actually tested in real our code base. |
rules/TypeDeclaration/Rector/StmtsAwareInterface/IncreaseDeclareStrictTypesRector.php
Outdated
Show resolved
Hide resolved
Member
|
Looks good, just one rule to ommit and its ready 👍 |
Member
Author
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
Member
|
Awesome :) |
Contributor
|
What about adding a short description for the I searched the reason why I have this warning in the output: In the codebase, I found that this rule is now enabled only in |
Member
Author
|
@andrew-demb good idea, could you add PR for it? It basically opiniated rules that match rector coding standard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative of #5923
Closes #5923