Skip to content
/ rector-src Public

[Printer] Apply configurable multiline on Fluent Method Call on print after method call created/re-printed#5779

Merged
TomasVotruba merged 14 commits intomainfrom
dx-muliline-fluent-call
Mar 28, 2024
Merged

[Printer] Apply configurable multiline on Fluent Method Call on print after method call created/re-printed#5779
TomasVotruba merged 14 commits intomainfrom
dx-muliline-fluent-call

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik commented Mar 28, 2024 •
edited
Loading

Can be enabled via Rector config:

return RectorConfig::configure()
     // ...
    ->withFluentCallNewLine()
    // ..
;

to ensure no BC break on rector extensions.

@samsonasik samsonasik marked this pull request as draft March 28, 2024 08:07
@samsonasik samsonasik force-pushed the dx-muliline-fluent-call branch from f3f8af6 to 8a23936 Compare March 28, 2024 08:12
@samsonasik samsonasik changed the title [Printer] Apply multiline on Fluent Method Call on print [Printer] Apply configurable multiline on Fluent Method Call on print Mar 28, 2024
@samsonasik samsonasik changed the title [Printer] Apply configurable multiline on Fluent Method Call on print [Printer] Apply configurable multiline on Fluent Method Call on print after method call created/re-printed Mar 28, 2024
@samsonasik samsonasik force-pushed the dx-muliline-fluent-call branch from c9266bb to 9cfbeb9 Compare March 28, 2024 14:13
@samsonasik samsonasik marked this pull request as ready for review March 28, 2024 14:53
@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Mar 28, 2024

All checks have passed 🎉 @TomasVotruba it is ready for review.

TomasVotruba
TomasVotruba approved these changes Mar 28, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@TomasVotruba TomasVotruba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work 💪

@TomasVotruba TomasVotruba merged commit 08d73a1 into main Mar 28, 2024
@TomasVotruba TomasVotruba deleted the dx-muliline-fluent-call branch March 28, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomasVotruba TomasVotruba TomasVotruba approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samsonasik @TomasVotruba @actions-user