[Transform] Adds ArrayDimFetchToMethodCallRector rule#5723
Merged
TomasVotruba merged 2 commits intorectorphp:mainfrom Mar 15, 2024
Merged
[Transform] Adds ArrayDimFetchToMethodCallRector rule#5723TomasVotruba merged 2 commits intorectorphp:mainfrom
TomasVotruba merged 2 commits intorectorphp:mainfrom
Conversation
staabm
reviewed
Mar 15, 2024
rules/Transform/Rector/ArrayDimFetch/ArrayDimFetchToMethodCallRector.php
Outdated
Show resolved
Hide resolved
Member
|
Looks good 👍 Thanks 🥳 |
samsonasik
reviewed
Mar 16, 2024
| } | ||
|
|
||
| foreach ($this->arrayDimFetchToMethodCalls as $arrayDimFetchToMethodCall) { | ||
| if (! $node->dim instanceof Node) { |
Member
There was a problem hiding this comment.
This check should be outside the loop, as return null early
samsonasik
reviewed
Mar 16, 2024
| } | ||
|
|
||
| if (! $this->isObjectType($node->var, new ObjectType($arrayDimFetchToMethodCall->getClass()))) { | ||
| return null; |
Member
There was a problem hiding this comment.
this should continue to next loop of configurable config instead of return null
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
In Laravel there's a few classes that use ArrayAccess to grab from the service container or config keys but it's not an overly popular way to do things anymore. This rule will be helpful to a few people I think who want to replace ArrayAccess implementing classes to use a specific method instead.