Add rector test suite to phpunit.xml or phpunit.xml.dist#5717
Merged
TomasVotruba merged 9 commits intorectorphp:mainfrom Mar 26, 2024
ghostwriter:oss/rectorphp/rector/issue-8486
Merged
Add rector test suite to phpunit.xml or phpunit.xml.dist#5717TomasVotruba merged 9 commits intorectorphp:mainfrom ghostwriter:oss/rectorphp/rector/issue-8486
rector test suite to phpunit.xml or phpunit.xml.dist#5717TomasVotruba merged 9 commits intorectorphp:mainfrom
ghostwriter:oss/rectorphp/rector/issue-8486
Conversation
Resolves rectorphp/rector#8486 Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Member
|
@ghostwriter could you fix phpstan notice at https://github.com/rectorphp/rector-src/actions/runs/8272661065/job/22634950125?pr=5717 ? create separate private method and call it and use assert or if check should solve it. Thank you. |
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
samsonasik
reviewed
Mar 16, 2024
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
samsonasik
reviewed
Mar 16, 2024
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com> Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
samsonasik
reviewed
Mar 16, 2024
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
samsonasik
approved these changes
Mar 16, 2024
Member
|
Thank you 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves rectorphp/rector#8486