Skip to content
/ rector-src Public

[Php55][Renaming] Handle rename string on combination StringClassNameToClassConstantRector+RenameStringRector#4869

Merged
samsonasik merged 5 commits intomainfrom
handle-rename-string
Aug 28, 2023
Merged

[Php55][Renaming] Handle rename string on combination StringClassNameToClassConstantRector+RenameStringRector#4869
samsonasik merged 5 commits intomainfrom
handle-rename-string

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik commented Aug 28, 2023 •
edited
Loading

Fixes rectorphp/rector#8160

StringClassNameToClassConstantRector directly use return NodeTraverser::DONT_TRAVERSE_CHILDREN on a refactor that cause other rule stopped:

rector-src/rules/Php55/Rector/String_/StringClassNameToClassConstantRector.php

Lines 110 to 116 in 1c56aa9

if ($node instanceof FuncCall) {
if ($this->isName($node, 'is_a')) {
return NodeTraverser::DONT_TRAVERSE_CHILDREN;
}
return null;
}

this should only stop below on current rule only.

This PR also a rework of PR:

@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Aug 28, 2023

@TomasVotruba it works 🎉

@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Aug 28, 2023

All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;)

@samsonasik samsonasik merged commit 684a317 into main Aug 28, 2023
@samsonasik samsonasik deleted the handle-rename-string branch August 28, 2023 05:26
@samsonasik samsonasik mentioned this pull request Aug 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RenameStringRector not run after StringClassNameToClassConstantRector

2 participants

@samsonasik @actions-user