[Php80] Handle crash parent default empty array/string param on AddParamBasedOnParentClassMethodRector#4833
Merged
samsonasik merged 18 commits intomainfrom Aug 23, 2023
Merged
Conversation
…entClassMethodRector
…entClassMethodRector
Member
Author
|
Fixed 🎉 /cc @klimslim |
Member
Author
|
All checks have passed 🎉 @TomasVotruba I think it is ready. |
staabm
reviewed
Aug 23, 2023
rules/Php80/Rector/ClassMethod/AddParamBasedOnParentClassMethodRector.php
Outdated
Show resolved
Hide resolved
Member
Author
TomasVotruba
approved these changes
Aug 23, 2023
Member
TomasVotruba
left a comment
There was a problem hiding this comment.
Go for merge when ready 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref https://getrector.com/demo/e913f712-f893-4504-a26d-1e73c3892e0d
Fixes rectorphp/rector#8149