[AutoImport] Handle case insensitive name collide on auto import#4829
[AutoImport] Handle case insensitive name collide on auto import#4829samsonasik merged 7 commits intomainfrom
Conversation
|
@staabm the issue seems when both class not yet imported, as the |
This reverts commit f2f25ba.
|
Fixed 🎉 /cc @staabm |
|
use const case insensitive is allowed, so I leave as is, see https://3v4l.org/lteVa |
|
All checks have passed 🎉 @TomasVotruba let's merge it to have faster feedback to test ;) |
|
thanks! |
|
do we have the same problem here? ? |
|
@staabm probably, could you create failing testcase at demo page https://getrector.com/demo or probably new fixture on ? https://github.com/rectorphp/rector-src/tree/main/tests/Issues/AutoImport/Fixture thank you. |
|
I think this one reproduces the problem: https://getrector.com/demo/4d8aeddb-8f37-4695-b322-491d4d719475 |
|
hmm no it doesn't. I guess my problem I see locally is caused, because the fix for this issue is not yet part of a release |
|
@staabm 0.18.1 just tagged https://github.com/rectorphp/rector/releases/tag/0.18.1 |
Fixes rectorphp/rector#8148