[TypeDeclaration] Deprecate ArrayShapeFromConstantArrayReturnRector as uses docblocks that we move away from since 0.15#4571
Merged
TomasVotruba merged 1 commit intomainfrom Jul 21, 2023
Conversation
ead873d to
f44778a
Compare
…s uses docblocks that we move away from since 0.15
f44778a to
400a8ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Rector 0.15 we move away from rules that create docblock types. Those types could create false feeling, that type is known and strict, while actually it's just text. Our goal is to use strict-type-based rules only, so we can trust the result and inter other types based on those.
Also in this particular case of array shapes, the best practise is to use value object with known types and validation 👍
This rule belongs to the group that was removed in 0.15, so this is cleanup of a forgotten left-over.
https://getrector.com/blog/new-in-rector-015-complete-safe-and-known-type-declarations