Introduces AddSensitiveParameterAttributeRector rule#4342
Merged
TomasVotruba merged 3 commits intorectorphp:mainfrom Jun 26, 2023
Merged
Introduces AddSensitiveParameterAttributeRector rule#4342TomasVotruba merged 3 commits intorectorphp:mainfrom
TomasVotruba merged 3 commits intorectorphp:mainfrom
Conversation
staabm
reviewed
Jun 25, 2023
...ctor/Param/AddSensitiveParameterAttributeRector/Fixture/apply_attribute_to_functions.php.inc
Show resolved
Hide resolved
samsonasik
reviewed
Jun 25, 2023
samsonasik
reviewed
Jun 26, 2023
...2/Rector/Param/AddSensitiveParameterAttributeRector/Fixture/skip_duplicate_attribute.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Jun 26, 2023
...2/Rector/Param/AddSensitiveParameterAttributeRector/Fixture/skip_duplicate_attribute.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Jun 26, 2023
...2/Rector/Param/AddSensitiveParameterAttributeRector/Fixture/skip_duplicate_attribute.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
requested changes
Jun 26, 2023
Member
samsonasik
left a comment
There was a problem hiding this comment.
I think it should live in Transform namespace since it optional and require configurable, something like ReturnTypeWillChangeRector
Member
|
@samsonasik That looks like a convention, but looking at the At the moment, lets go with PHP category here 👍 |
Member
|
Thank you @peterfox for the rule 👍 |
Contributor
Author
|
@TomasVotruba thank you for merging it! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
PHP 8.2 introduced a SensitiveParameter attribute to stop strings from appearing in stack traces. This Rule makes it easy to list the names of parameters you would like the attribute applied upon.